Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template issues #17

Merged
merged 3 commits into from
May 11, 2020
Merged

Fix template issues #17

merged 3 commits into from
May 11, 2020

Conversation

yuqu
Copy link
Contributor

@yuqu yuqu commented May 11, 2020 •
edited
Loading

Fields from react-docgen will not be fed into code snippet template unless they have one of type, flowType or tsType fields.

Fixes: #16 #18

@yuqu yuqu requested review from dirtybit, ergunsh and skarahoda May 11, 2020 12:02
@yuqu yuqu mentioned this pull request May 11, 2020
Closed
@yuqu yuqu merged commit b2dec22 into master May 11, 2020
@yuqu yuqu deleted the fix-template-issues branch May 11, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarahoda skarahoda skarahoda approved these changes

@dirtybit dirtybit Awaiting requested review from dirtybit

@ergunsh ergunsh Awaiting requested review from ergunsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'name' of undefined
2 participants
@yuqu @skarahoda